This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Random span-based API #13708
Merged
Random span-based API #13708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 30, 2017 14:54
danmoseley
reviewed
Aug 30, 2017
| for (int i = 0; i < buffer.Length; i++) | ||
| { | ||
| buffer[i] = (byte)(InternalSample() % (Byte.MaxValue + 1)); | ||
| buffer[i] = (byte)InternalSample(); |
There was a problem hiding this comment.
why did you remove % (Byte.MaxValue + 1)); ? Although, I'm not sure what it was for.
There was a problem hiding this comment.
Ah I think it's redundant, the byte cast is enough. Fine.
danmoseley
approved these changes
Aug 31, 2017
dotnet-bot
pushed a commit
to dotnet/corert
that referenced
this pull request
Sep 1, 2017
* Span NextBytes * int fixes * undo ints Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Sep 1, 2017
* Span NextBytes * int fixes * undo ints Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NextBytes functionality for Span to Random class outlined in https://github.com/dotnet/corefx/issues/22356.