Do not honor attribute HandleProcessCorruptedStateExceptions #10957
Conversation
|
It does not do full cleanup of all the code required for handling HandleProcessCorruptedStateExceptions Attribute. But removes its functionality. |
|
PTAL @jkotas @gkhanna79 |
|
Can we fail fast immediately when the corrupting exception hits the managed code? It sounds like we will still run a lot of code (looking for handlers, etc.) with this fix when this happens. |
src/vm/excep.cpp
Outdated
| // Method is in a Pre-V4 assembly - allow it to be examined for processing the CE | ||
| fLookForExceptionHandlersInMethod = TRUE; | ||
| } | ||
| fLookForExceptionHandlersInMethod = FALSE; |
There was a problem hiding this comment.
This is not an appropriate change - not only we are incompletely removing the functionality but if we need to add additional policies for this feature, this will not be available.
The right fix would be to check for CorruptionSeverity against the ExceptionTracker/ExInfo, when it is setup early in the personality routine, and failfast if it is corrupting.
|
can you PTAL this now terminates the process in first pass of EH. I also modified a jit calli tests which was depending on HandleProcessCorruptedState attribute. I will add tests for this changed functionality in corefx repo. |
Fixes #9045