-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API-diff between 7.0-preview2 and 7.0-preview3 #7396
Conversation
I am seeing something strange in the system namespace. here is some example:
Is this intentional? |
I am not seeing |
The following System.Diagnostics APIs LGTM. public class Activity : IDisposable {
+ public bool HasRemoteParent { get; }
}
public readonly struct ActivityCreationOptions<T> {
+ public string? TraceState { get; set; }
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Microsoft.WindowsDesktop.App
APIs look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M.E.Logging/Caching/Configuration/Primitives diff LGTM.
cc @halter73 for Hosting
|
...view/api-diff/preview3/Microsoft.AspNetCore.App/7.0-preview3_Microsoft.Extensions.Hosting.md
Show resolved
Hide resolved
That's my understanding, @tarekgh - We do not include OOBs in this report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crypto LGTM
The bugs we found in the API diffs for Preview1 and Preview2 were fixed here: dotnet/arcade#9172
ASP.NET: @dotnet/aspnet-api-review
WinForms: @merriemcgaw @RussKie
WPF: @dreddy-work @RussKie
Libraries: @danmoseley @jeffhandley @karelz @ericstj @stephentoub
@dotnet/area-extensions-filesystem
@dotnet/area-extensions-hosting
@dotnet/area-extensions-logging
@dotnet/area-extensions-primitives
@dotnet/area-system-runtime
@dotnet/area-system-numerics
@dotnet/area-system-diagnostics-activity
System.Net: @dotnet/ncl
@dotnet/interop-contrib
@dotnet/area-system-security
@dotnet/area-system-text-regularexpressions