Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update to latest core-setup and clean up #7530

Merged

Conversation

nguerrera
Copy link
Contributor

@nguerrera nguerrera commented Aug 25, 2017

Resolved conflicts for #6942 (I don't have push access to that). Gets everything on latest core-setup, not just runtime. Hopefully the pump is unblocked after this.
Unpinned stage0
Retargeted to netcoreapp2.1 to fix build
Re-enabled tests that were disabled against msbuild quoting bug on netcoreapp2.1
Finally got rid of the warnings in the build. Fixes #7350

@eerhardt

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when green

@nguerrera nguerrera force-pushed the dotnet-bot-master-UpdateDependencies branch from d811bae to ea6b970 Compare August 26, 2017 01:39
@nguerrera nguerrera changed the title Update CoreSetup to preview2-25616-02 Update CoreSetup to preview2-25616-02 and clean up Aug 26, 2017
@nguerrera nguerrera force-pushed the dotnet-bot-master-UpdateDependencies branch from 64b7b81 to 497f6c5 Compare August 26, 2017 03:19
@nguerrera nguerrera changed the title Update CoreSetup to preview2-25616-02 and clean up Update to latest core-setup and clean up Aug 26, 2017
@@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="5.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="5.0.1" />

This comment was marked as spam.

This comment was marked as spam.

@@ -6,6 +6,9 @@
<RuntimeFrameworkVersion>$(CLI_SharedFrameworkVersion)</RuntimeFrameworkVersion>
<AssemblyName>Msbuild.Tests.Utilities</AssemblyName>
<AssetTargetFallback>$(AssetTargetFallback);dotnet5.4;portable-net451+win8</AssetTargetFallback>
<AssemblyOriginatorKeyFile>../../tools/Key.snk</AssemblyOriginatorKeyFile>

This comment was marked as spam.

This comment was marked as spam.

@@ -1,3 +1,6 @@
<Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="build/DependencyVersions.props" />
<PropertyGroup>
<NoPackageAnalysis>true</NoPackageAnalysis>

This comment was marked as spam.

This comment was marked as spam.

@@ -24,7 +24,7 @@
<PackageReference Include="NuGet.ProjectModel" Version="$(CLI_NuGet_Version)" />
<PackageReference Include="Microsoft.Build" Version="$(CLI_MSBuild_Version)" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(CLI_MSBuild_Version)" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.0.0" />
<PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />

This comment was marked as spam.

This comment was marked as spam.

@@ -6,7 +6,6 @@ namespace Microsoft.DotNet.Cli
///
/// <summary>Allows control flow to be interrupted in order to display help in the console.</summary>
///
[Obsolete("This is intended to facilitate refactoring during parser replacement and should not be used after that work is done.")]

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

<!-- Only use asset target fallback that we set (not implicit one to net461). -->
<DisableImplicitAssetTargetFallback>true</DisableImplicitAssetTargetFallback>

<!-- Disable asset target fallback warning globally since it does not work transitively on NoWarn of individual packages -->

This comment was marked as spam.

This comment was marked as spam.

<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0-beta4-build1194" />
<PackageReference Include="xunit" Version="2.2.0-beta4-build3444" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />

This comment was marked as spam.

This comment was marked as spam.

@nguerrera nguerrera merged commit a7eba4d into dotnet:master Aug 26, 2017
@nguerrera nguerrera deleted the dotnet-bot-master-UpdateDependencies branch August 26, 2017 17:14
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<CLI_SharedFrameworkVersion>2.0.0</CLI_SharedFrameworkVersion>
<CLI_SharedFrameworkVersion>2.1.0-preview2-25616-02</CLI_SharedFrameworkVersion>

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.cmd spews out hundreds of warnings
7 participants