Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update solution to reflect current state #7352

Merged
merged 4 commits into from
Aug 2, 2017
Merged

Conversation

davkean
Copy link
Member

@davkean davkean commented Aug 2, 2017

Solution was out of date with respect to the current state of the repo.

Fixes: https://github.com/dotnet/cli/issues/7351.

@davkean davkean requested a review from a team August 2, 2017 08:45
@dnfclas
Copy link

dnfclas commented Aug 2, 2017

@davkean,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@davkean
Copy link
Member Author

davkean commented Aug 2, 2017

@dotnet/dotnet-cli It's not clear to me why the Ubuntu build failed:

02:10:27          Test execution time: 2.5310 Minutes
02:10:27 �[39;49m�[30m         Test Run Failed.
02:10:27 �[39;49m         Results File: /opt/code/test/dotnet.Tests/TestResults/_32bd9fbf8fa1_2017-08-02_09_07_58.trx
02:10:27          VSTest: Exit code: 1
02:10:28 �[?1h�=�[39;49m�[36m    15>�[39;49m�[39;49m�[36mDone Building Project "/opt/code/build/test/RunTest.proj" (default targets) -- FAILED.
02:10:28 �[39;49m�[39;49m�[36m     1>�[39;49m�[39;49m�[36mDone Building Project "/opt/code/build.proj" (default targets) -- FAILED.
02:10:28 �[39;49m
02:10:28 Build FAILED.

@wli3
Copy link

wli3 commented Aug 2, 2017

@davkean you can see the failing test result from here

image

@wli3
Copy link

wli3 commented Aug 2, 2017

@davkean this again https://github.com/dotnet/cli/issues/4660

You can re queue it by "@dotnet-bot test Ubuntu x64 Release Build"

@wli3
Copy link

wli3 commented Aug 2, 2017

looks good to me @johnbeisner what do you think?

@nguerrera
Copy link
Contributor

Looks good. Are those RelWithDebInfo, MinSizeRel, etc. configurations used. It's wiring them to debug project configurations which looks wrong. I think we should delete the solution configurations.

@davkean
Copy link
Member Author

davkean commented Aug 2, 2017

Are they solution configurations only or coming from projects?

@davkean davkean merged commit 8476bbb into dotnet:master Aug 2, 2017
@nguerrera
Copy link
Contributor

Search turns them up only in the sln. I think they're dead code. Official builds don't use the sln.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants