Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Use MacOS-13 in CI #58549

Merged
merged 8 commits into from
Nov 14, 2024
Merged

[release/8.0] Use MacOS-13 in CI #58549

merged 8 commits into from
Nov 14, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Oct 21, 2024

No description provided.

@wtgodbe wtgodbe requested review from BrennanConroy, halter73 and a team as code owners October 21, 2024 17:17
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 21, 2024
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 21, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Oct 21, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 28, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 13, 2024

A JSON parsing exception occurred in [/__w/1/s/artifacts/source-build/self/src/global.json], offset 743 (line 31, column 1): Missing a comma or '}' after an object member.

@dotnet/source-build any idea why the global.json changes in this PR would cause a JSON parsing error, only in the source-build job? The JSON in global.json does appear to be valid, so not sure what's going on

@mthalman
Copy link
Member

A JSON parsing exception occurred in [/__w/1/s/artifacts/source-build/self/src/global.json], offset 743 (line 31, column 1): Missing a comma or '}' after an object member.

@dotnet/source-build any idea why the global.json changes in this PR would cause a JSON parsing error, only in the source-build job? The JSON in global.json does appear to be valid, so not sure what's going on

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 14, 2024

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

Interesting, is that a known thing w/ how SourceBuild parses global.json? I'm curious why it only happened there

@mthalman
Copy link
Member

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

Interesting, is that a known thing w/ how SourceBuild parses global.json? I'm curious why it only happened there

Not specific to source build. It's a general Linux thing. Certain Linux tools do not play nicely with files formatted that way. That's why GitHub has UI that alerts you to a missing newline. So likely source build is executing something in the context of Linux that doesn't like this.

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 14, 2024
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 14, 2024

Failures unrelated

@wtgodbe wtgodbe merged commit ed659d7 into release/8.0 Nov 14, 2024
22 of 25 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/Mac138.0 branch November 14, 2024 19:41
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.12 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants