Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Dispose CTS in HubConnection streaming #51138

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2023

Backport of #51117 to release/7.0

/cc @BrennanConroy

Dispose CTS in HubConnection streaming

Description

Fixes a memory leak in the SignalR client when using streaming.

Customer Impact

Noticed by customer when running a service with a client for multiple weeks and seeing large memory usage. Could also be seen by a more active client that makes a lot of streaming calls.

Regression?

  • Yes
  • No

Looks like it's been there since 3.X

Risk

  • High
  • Medium
  • Low

Simple disposal of an object once it's done being used.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Oct 4, 2023
@ghost ghost added this to the 7.0.x milestone Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@BrennanConroy BrennanConroy added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Oct 4, 2023
@ghost
Copy link

ghost commented Oct 4, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@wtgodbe
Copy link
Member

wtgodbe commented Oct 4, 2023

@BrennanConroy @halter73 I can merge this once it gets code reviewed

@wtgodbe
Copy link
Member

wtgodbe commented Oct 5, 2023

Components failure is unrelated & has been fixed, merging

@wtgodbe wtgodbe merged commit 794c22c into release/7.0 Oct 5, 2023
24 of 26 checks passed
@wtgodbe wtgodbe deleted the backport/pr-51117-to-release/7.0 branch October 5, 2023 16:23
@ghost ghost modified the milestones: 7.0.x, 7.0.13 Oct 5, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-signalr Includes: SignalR clients and servers Servicing-approved Shiproom has approved the issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants