Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BinSkim scan in nightly validation #49324

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

MilenaHristova
Copy link
Member

@MilenaHristova MilenaHristova commented Jul 11, 2023

Enable BinSkim scan in nightly validation

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Enabling BinSkim scan over build artifacts in Validate-DotNet pipeline and the .NET staging pipeline based on company requirements.

We are required to run SDL tools on official builds and implement automated bug filling for the tools output. Currently we are running SDL checks over the source code in the nightly builds and in the .NET staging pipeline, but to be compliant we need to also run BinSkim over the produced artifacts.

This PRs is enabling BinSkim checks in the nightly run of Validate-DotNet pipeline.

More information is in the Automate BinSkim runs over official builds issue

@MilenaHristova MilenaHristova requested review from a team and wtgodbe as code owners July 11, 2023 08:39
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe merged commit 139d017 into dotnet:main Jul 11, 2023
25 checks passed
@ghost ghost added this to the 8.0-preview7 milestone Jul 11, 2023
@MilenaHristova MilenaHristova deleted the mhristova/enable-binskim-scan branch July 12, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants