Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template tests to run in CI #46430

Closed
4 tasks
TanayParikh opened this issue Feb 3, 2023 · 4 comments
Closed
4 tasks

Fix template tests to run in CI #46430

TanayParikh opened this issue Feb 3, 2023 · 4 comments
Assignees
@MackinnonBuck
Labels
area-blazor Includes: Blazor, Razor Components feature-playwright 🎭 This issue is related to Playwright E2E Project Template Tests Pillar: Technical Debt Priority:0 Work that we can't release without task
Milestone
9.0-preview7

Comments

@TanayParikh
Copy link
Contributor

Following tests are failing in the CI only (works fine locally), seems to be due to searching for the StaticFiles dependency. Unclear what exactly is pulling this dependency.

  • BlazorWasmHostedTemplate_Works
  • BlazorServerTemplate_IdentityWeb_BuildAndPublish
  • BlazorWasmHostedTemplate_IndividualAuth_Works_WithLocalDB
  • BlazorWasmHostedTemplate_IndividualAuth_Works_WithOutLocalDB
@TanayParikh TanayParikh added area-blazor Includes: Blazor, Razor Components feature-playwright 🎭 This issue is related to Playwright E2E Project Template Tests labels Feb 3, 2023
TanayParikh added a commit that referenced this issue Feb 3, 2023
@TanayParikh
Add #46430
c2d7a88
@TanayParikh TanayParikh mentioned this issue Feb 3, 2023
Merged
TanayParikh added a commit that referenced this issue Feb 3, 2023
@TanayParikh
Unskip #46430
e1c904c
@TanayParikh
Copy link
Contributor Author

https://dev.azure.com/dnceng-public/public/_build/results?buildId=158385&view=results

@mkArtakMSFT mkArtakMSFT added this to the 8.0-preview2 milestone Feb 7, 2023
wtgodbe added a commit that referenced this issue Feb 14, 2023
@TanayParikh @wtgodbe
Playwright 🎭 🛠️ (#45682)
c429024 
* Version Bumps

* Run with `Test: Windows Server x64`

* Install Playwright in CI

* Add running playwright locally instructions

* Test Cleanup

* Remove Selenium

* Prebuild for Playwright install

* Update default-build.yml

* Update default-build.yml

* Update default-build.yml

* Update default-build.yml

* Update default-build.yml

* Playwright install in test

* New template test pipeline

* Update components-e2e-tests.yml

* Update components-template-tests.yml

* Update components-e2e-tests.yml

* Update components-e2e-tests.yml

* Update components-e2e-tests.yml

* Update components-template-tests.yml

* Update components-e2e-tests.yml

* Update components-e2e-tests.yml

* Update components-e2e-tests.yml

* Revert new pipeline changes

* RestoreAdditionalProjectSources

* Update Templates.Blazor.Tests.csproj

* PR Feedback

* RunBlazorPlaywrightTemplateTests

* Socket logic

* Fixed socket wait logic

Fixes #30761

* Remove redundant process wait for exit

We're already in the `Exited` Event:

There are two ways of being notified when the associated process exits: synchronously and asynchronously. Synchronous notification means calling the WaitForExit method to block the current thread until the process exits. Asynchronous notification uses the Exited event, which allows the calling thread to continue execution in the meantime. In the latter case, EnableRaisingEvents must be set to true for the calling application to receive the Exited event.

https://learn.microsoft.com/dotnet/api/system.diagnostics.process.exited?view=net-7.0

* Update BlazorWasmTemplateTest.cs

* Update Templates.Blazor.Tests.csproj

* Revert App.Ref, add src in props

* Config updates

* Update RequiresDelayedBuildProjects.props

* Update Templates.Blazor.Tests.csproj

* Skip failing tests

* Add #46430

* Update Templates.Blazor.Tests.csproj

* Update BlazorWasmTemplateTest.cs

* Update BlazorWasmTemplateTest.cs

---------

Co-authored-by: William Godbe <wigodbe@microsoft.com>
@wtgodbe
Copy link
Member

wtgodbe commented Feb 14, 2023

Fixed by #45682

@wtgodbe wtgodbe closed this as completed Feb 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2023
@halter73
Copy link
Member

We missed one:

aspnetcore/src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs

Lines 62 to 65 in f9121bc

[Theory(Skip="https://github.com/dotnet/aspnetcore/issues/46430")]
[InlineData(BrowserKind.Chromium)]
public async Task BlazorWasmHostedTemplate_Works(BrowserKind browserKind)
{

We also skip the only other Playwright test in the entire assembly:

aspnetcore/src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWasmTemplateTest.cs

Lines 26 to 28 in f9121bc

[Theory(Skip="https://github.com/dotnet/aspnetcore/issues/47225")]
[InlineData(BrowserKind.Chromium)]
public async Task BlazorWasmStandaloneTemplate_Works(BrowserKind browserKind)

That issue is at least open, but it says the test is "Quarantined" when in fact it's really skipped.

@halter73 halter73 reopened this Oct 11, 2023
@halter73 halter73 removed this from the 8.0-preview2 milestone Oct 11, 2023
@mkArtakMSFT mkArtakMSFT added this to the .NET 9 Planning milestone Oct 11, 2023
@mkArtakMSFT mkArtakMSFT changed the title Blazor Playwright Tests StaticFiles Dependency Fix template tests to run in CI Jan 9, 2024
@mkArtakMSFT mkArtakMSFT added the Priority:0 Work that we can't release without label Jan 9, 2024
@MackinnonBuck
Copy link
Member

Resolved by #54606

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components feature-playwright 🎭 This issue is related to Playwright E2E Project Template Tests Pillar: Technical Debt Priority:0 Work that we can't release without task
Projects
None yet
Milestone
9.0-preview7
Development

No branches or pull requests
5 participants
@halter73 @MackinnonBuck @wtgodbe @TanayParikh @mkArtakMSFT