Startup performance improvements #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes some tweaks to instrumentation
karolz-ms
commented
Oct 5, 2023
| @@ -111,16 +109,6 @@ private async Task EnsureDcpHostRunningAsync(CancellationToken cancellationToken | |||
| } | |||
|
|
|||
| (_, _dcpRunDisposable) = ProcessUtil.Run(dcpProcessSpec); | |||
|
|
|||
| try | |||
There was a problem hiding this comment.
With the retry logic that we now have in KubernetesService we simply do not need this check
karolz-ms
commented
Oct 5, 2023
| @@ -11,7 +11,7 @@ | |||
| <PropertyGroup> | |||
| <!-- Package versions defined directly in <reporoot>/Directory.Packages.props --> | |||
| <MicrosoftDotnetSdkInternalPackageVersion>8.0.100-rc.1.23422.1</MicrosoftDotnetSdkInternalPackageVersion> | |||
| <_DcpVersion>0.1.31-rc.6</_DcpVersion> | |||
| <_DcpVersion>0.1.32-rc.6</_DcpVersion> | |||
There was a problem hiding this comment.
This version should bring significant startup time reduction for DCP
There was a problem hiding this comment.
Should this just be 0.1.32 instead of 0.1.32-rc.6?
There was a problem hiding this comment.
The Nuget restore was very unhappy when I only had 0.1.32 and told me the latest version was 0.1.32-rc.6 🤷♂️ Not sure what adds the -rc.6 part...
There was a problem hiding this comment.
I'll take a look at the builds later; should be the exact same bits as 0.1.32 anyway, so not critical to fix right now.
danegsta
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some tweaks to instrumentation