Use DCP injected values for OTEL service id and name #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the OTEL names consistent with DCP names. It fixes the problem of replicas, e.g.
catalogservice
, being duplicated. Now the OTEL name matches what is displayed on the projects page.I'd like guidance on how this pattern will work when deployed to other environments. Do they ignore/overwrite the env vars set for service id and name and apply their own? Does this PR need to change to reflect that?
Once this approach is verified as good then port the changes to the template.Note: this change relies on a preview build of DCP that isn't in the workload yet. The right version of DCP should be available in a few days.