[release/9.0] Remove Milvus.Client dependency. (#6435) #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Milvus.Client dependency. * namespaces! * Fix random change.
eerhardt
approved these changes
Oct 23, 2024
|
Low Risk, and enables us to ship a package as stable as opposed to force us to prerelease. Approved. |
joperezr
approved these changes
Oct 23, 2024
|
Can we please also add to this the change to remove the SuppressFinalPackageVersion line in the hosting project so we can produce a stable version of this? |
|
Happy to push the change directly here if that's ok |
eerhardt
approved these changes
Oct 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
flakey test endpoint tests. |
This was referenced Oct 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Open
3 tasks
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
joperezr
added a commit
to joperezr/aspire
that referenced
this pull request
Nov 13, 2024
…/9.0 #### AI description (iteration 1) #### PR Classification Code cleanup and dependency updates. #### PR Summary This pull request merges changes from `release/9.0` into `internal/release/9.0`, addressing several work items related to security, dependency updates, and code cleanup. - Removed `MilvusClient` creation logic and health checks from `src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs`. - Updated various package dependencies in `Directory.Packages.props` and `eng/Version.Details.xml`. - Added `AssemblyInfo.cs` to `src/Aspire.Hosting.Python` to mark it as experimental. - Updated container image tags in `src/Aspire.Hosting.Milvus`, `src/Aspire.Hosting.MySql`, `src/Aspire.Hosting.Elasticsearch`, and `src/Aspire.Hosting.Keycloak`. - Removed deprecated package references and suppressed final package version in `src/Aspire.Hosting.Milvus/Aspire.Hosting.Milvus.csproj`. Related work items: dotnet#5994, dotnet#6054, dotnet#6298, dotnet#6377, dotnet#6417, dotnet#6435, dotnet#6451, dotnet#6460, dotnet#6498
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6435 to release/9.0
Customer Impact
In
Aspire.Hosting.Milvuswe automatically add a health check when callingAddMilvus(...). This takes a dependency onMilvus.Clientwhich does not have a stable release. We've made the decision to remove the apphost-side health check for now.Testing
Removed feature and unit test. Existing tests pass.
Risk
Low.
Regression?
No
Microsoft Reviewers: Open in CodeFlow