Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod +x start-code.sh #5566

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chmod +x start-code.sh #5566

merged 1 commit into from
Sep 6, 2024

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Sep 5, 2024 •
edited by dotnet-policy-service bot
Loading

The start-code.sh script doesn't have the correct permissions for execution configured while other scripts in the repo do.

Before:

$ git ls-files -s *.sh    
100755 de07bc60243852297f0e4013c94308f86654970b 0       build.sh
100755 6d370b5a2b4bcafb2cc2d0f147b259e3880d5605 0       dogfood.sh
100755 93a37ffacfda35cba001748a81fba39be013ae07 0       dotnet.sh
100644 aa17600387ab23d710f7d1c9435f3280df5b79b8 0       start-code.sh

After:

$ git ls-files -s *.sh
100755 de07bc60243852297f0e4013c94308f86654970b 0       build.sh
100755 6d370b5a2b4bcafb2cc2d0f147b259e3880d5605 0       dogfood.sh
100755 93a37ffacfda35cba001748a81fba39be013ae07 0       dotnet.sh
100755 aa17600387ab23d710f7d1c9435f3280df5b79b8 0       start-code.sh
Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2024
@joperezr joperezr added area-engineering-systems infrastructure helix infra engineering repo stuff and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 5, 2024
joperezr
joperezr approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @captainsafia!

@captainsafia captainsafia enabled auto-merge (squash) September 5, 2024 23:15
@captainsafia captainsafia merged commit 514e386 into main Sep 6, 2024
11 checks passed
@captainsafia captainsafia deleted the safia/chmod-start-code branch September 6, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @joperezr