Add AddParameter overloads that take a constant and a ParameterDefault

[davidebbo]

Description

See #5410 for details.

Fixes #5410

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No, may not be necessary here.
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Link to aspire-docs issue: None opened yet.
  • No

Microsoft Reviewers: Open in CodeFlow

[eerhardt]

This LGTM. Thanks for the contribution, @davidebbo!

@DamianEdwards @davidfowl @mitchdenny - any other thoughts?

[davidfowl]

I'm struggling with this one. Why is defaultValue a fallback instead of an override?

[eerhardt]

It's the "default value". I.e. "if no one else supplied a value - use this one".

We would call it string value, if we wanted to always win.

[davidfowl]

fallback value?

[davidebbo]

Sounds like a continuation of your earlier conversation: #4429 (comment). And frankly, I'm a bit confused about the comment there that says that "code wins". To me, "config wins", and the code is a fall back, which is what my code is doing.

[eerhardt]

In C#, when you have "optional arguments", the value that is used if you don't supply a value to the argument is called a "default value":

https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/named-and-optional-arguments#optional-arguments

Each optional parameter has a default value as part of its definition. If no argument is sent for that parameter, the default value is used.

[davidebbo]

In C#, when you have "optional arguments", the value that is used if you don't supply a value to the argument is called a "default value"

Right, though this is quite different from our situation here, where the value can come from two completely different systems (config vs code). Here, I could see fallbackValue as a reasonable name, though I don't think defaultValue is so bad either.

[davidebbo]

Started Discord thread to make it easier to discuss: https://discord.com/channels/732297728826277939/1281287950491193436