Allow env var with no name in dashboard #5323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dashboard was crashing because a user had an env var on their machine with no name.
This PR changes the dashboard to allow env var with no name in dashboard. Not ideal, but better than crashing, or losing data.
Fixes #5309
Can reproduce empty env var via:
Note that resource is created by DCP but fails to start. I'm going to create a follow up issue to validate env vars set by the model always have a key. That way the host fails with a good error message before the DCP or dashboard start. Note that still doesn't stop an empty name env var from the OS.
Update: #5324
Checklist
<remarks />
and<code />
elements on your triple slash comments?