Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] DockerUtils.AttemptDeleteDockerVolume - allow throwing on failures #5315

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

radical
Copy link
Member

@radical radical commented Aug 15, 2024

.. failures. This is useful when expecting to create a fresh new volume,
and this would cause an exception to be thrown if a volume with the same
name could not be deleted.

Microsoft Reviewers: Open in CodeFlow

.. failures. This is useful when expecting to create a fresh new volume,
and this would cause an exception to be thrown if a volume with the same
name could not be deleted.
@radical radical requested a review from mitchdenny as a code owner August 15, 2024 21:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Aug 15, 2024
@radical radical added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️ and removed area-integrations Issues pertaining to Aspire Integrations packages labels Aug 15, 2024
@radical radical changed the title [tests] DockerUtils.AttemptDeleteDockerVolume - allow throwing on [tests] DockerUtils.AttemptDeleteDockerVolume - allow throwing on failures Aug 15, 2024
@radical radical enabled auto-merge (squash) August 16, 2024 03:07
@radical radical merged commit b74f2c6 into dotnet:main Aug 16, 2024
11 checks passed
@radical radical deleted the tests-vol-fail branch August 16, 2024 03:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants