Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better log viewing status information #53

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Better log viewing status information #53

merged 1 commit into from
Oct 4, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 4, 2023

It can be hard to tell what state the Container/Project logs pages are in. Is it actually watching the logs? Is it waiting for the project to start? So this PR takes a first stab at adding some state information here:

  1. The State of Projects/Containers are displayed within the dropdown IIF they're not Running.
  2. A status message is displayed next to the dropdown with an initial set of statuses as the page loads, containers/projects are discovered, logs become available, log watching starts, etc.
  3. The old InitialText from the LogViewer is removed in favor of the above status info.
  4. Simplified the Clear/Cancel/Dispose code when the selected container/project changes
  5. Fixed a bug in the timestamp detection

Note: There appears to be a bug where the text of the selected item in the FluentSelect doesn't update when the underlying option changes (e.g. when the current selected text changes from "myfrontend (Unknown State)" to "myfrontend", the value of the option in the dropdown list changes, but the displayed selected value does not). I haven't gotten a simple repro of that yet, but will file a bug on it. @vnbaaij FYI on that, I'm not sure if it is in FluentUI-Blazor or in the underlying web components (I think it might be the latter).

@tlmii tlmii requested a review from smitpatel October 4, 2023 06:55
@tlmii
Copy link
Member Author

tlmii commented Oct 4, 2023

image

It's kind of unfortunate that we don't have an actual state value when things are starting up.

{
await DisposeCurrentWatcher();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont need this code anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed at that point anymore because it is done when the drop down selection changes. So it's still done, just earlier in the process.

@tlmii tlmii merged commit 58ae089 into dotnet:main Oct 4, 2023
@smitpatel smitpatel deleted the dev/clean-up-logs-and-show-status branch October 4, 2023 23:56
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants