-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection-level security to frontend #5261
Conversation
To confirm understanding, the issue before this PR was that a user can auth for OTLP HTTP then use that token to view the Dashboard? |
I'm not sure. I didn't test what happens when someone accessed the browser dashboard when there wasn't a frontend cookie. However, it was possible to view the dashboard via the OTLP HTTP port, which we want to prevent regardless of whether you're authenticated to view the dashboard or not. |
It would be useful if you double checked ODIC still works. The test passes, but I'm not sure if that completely verifies it is working. I believe there was a manual test you ran when that auth type was added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some nits.
I believe there was a manual test you ran when that auth type was added.
The manual test was for certificates, and Bala's team are running that test now. The OIDC tests here look good to me.
src/Aspire.Dashboard/Authentication/FrontendCompositeAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Dashboard/Authentication/FrontendCompositeAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Dashboard/Authentication/Connection/ListenOptionsConnectionTypeExtensions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Drew Noakes <git@drewnoakes.com>
Description
This PR adds connection-level security to the frontend. The frontend can now only be accessed via the frontend point.
This change is required because the OTLP HTTP endpoint supports being accessed via browser, and we don't want people to be able to browser the dashboard UI via the OTLP HTTP endpoint.
Checklist
<remarks />
and<code />
elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow