-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CORS for with OTLP HTTP endpoint and add playground app #5212
Conversation
Just thinking whether we need a threat model for this if only just to verify that we've though that we aren't making anything less secure by setting CORS up for all the resource endpoints. I don't think we do because someone who has compromised a web UI on one of the resource endpoints probably has control of the container the UI was launched from, at which point CORS isn't relevant. |
Yes, that's the plan. I'm certain it will be fine, but it should be mentioned in those docs. |
a2aaa21
to
85fa5f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Added a few comments but nothing that should block.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Fixes #4917
This PR:
opentelemetry-js
SDK to send OTLP data to the dashboard.Demo:

The eagle eyed might have noticed that the browser span started before the server span. It's caused by the browser and server clocks not being perfectly synced. They are off by about 10ms. As far as I can tell there isn't anything that we can do about it.
Microsoft Reviewers: Open in CodeFlow