[tests] Add resource logging to Aspire.Hosting.* tests
#5193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-integrations
…xunit, with resource logging
…sts also now, so fix build by fully qualifying some types
radical
force-pushed
the
add-logging-to-tests
branch
from
c91c177 to
4938cb3
Compare
radical
requested review from
eerhardt,
sebastienros,
ReubenBond,
mitchdenny and
joperezr
and removed request for
ReubenBond and
mitchdenny
1 task
eerhardt
approved these changes
Aug 6, 2024
|
We won't need #4965 after that |
radical
commented
Aug 6, 2024
Comment on lines
4
to
6
| #pragma warning disable IDE0005 // Using directive is unnecessary. This warning happens when building this file in Aspire.Hosting.Tests.csproj | ||
| using Aspire.Hosting.ApplicationModel; | ||
| #pragma warning restore IDE0005 // Using directive is unnecessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overloads to
TestDistributedApplicationBuilder.CreatewithITestOutputHelperto add xunit, and resource logging. And a.WithTestAndResourceLogging()to help with otherCreatemethods.Rest of the changes per test project remove the helper methods, and update the calls to use the new changes from above.
This will help with debugging flaky test failures on CI.
Suggested by @Alirexaa in #5140 (comment) .
Microsoft Reviewers: Open in CodeFlow