Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a default TLS version for Azure SQL to 1.2 #5043

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Jul 24, 2024

Updated tests and added tests to validate user-specified override

Fixes #5042

Microsoft Reviewers: Open in CodeFlow

Updated tests and added tests to validate user-specified override

Fixes dotnet#5042
@aaronpowell aaronpowell requested a review from mitchdenny as a code owner July 24, 2024 06:14
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jul 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2024
@mitchdenny
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt eerhardt changed the title Setting a default TLS version for Azure SQL to 1.3 Setting a default TLS version for Azure SQL to 1.2 Aug 22, 2024
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@eerhardt eerhardt enabled auto-merge (squash) August 22, 2024 00:32
@eerhardt eerhardt merged commit 255dd2f into dotnet:main Aug 22, 2024
11 checks passed
@aaronpowell aaronpowell deleted the aaronpowell/issue-5042 branch September 9, 2024 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure SQL deploys without setting TLS version
3 participants