[release/8.1] Backport: Add GetEnvironmentVariableValuesAsync method to ResourceExtens…
#5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons (#4530) * Add to ResourceExtensions ```GetEnvironmentVariableValuesAsync``` #4464 * add example and remarks * add test * Update src/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs Co-authored-by: Damian Edwards <damian@damianedwards.com> * Update src/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Update src/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs Co-authored-by: Ankit Jain <radical@gmail.com> * add more tests,add suggested code * Tweak API based on Eric's feedback. * Use a different example. * Update src/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Remove password from example. * Indentation fixes. * Update tests/Aspire.Hosting.Tests/ResourceExtensionsTests.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Update tests/Aspire.Hosting.Tests/ResourceExtensionsTests.cs Co-authored-by: Ankit Jain <radical@gmail.com> * PR feedback. * Namespace fix. --------- Co-authored-by: Mitch Denny <midenn@microsoft.com> Co-authored-by: Damian Edwards <damian@damianedwards.com> Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> Co-authored-by: Mitch Denny <mitchdenny@outlook.com>
dotnet-issue-labeler
bot
added
the
area-app-model
|
IMO it's too late for this so I'd just wait for the next train for this one. @danmoseley thoughts? That said, I don't think you've filled out the template so if you could explain why you think this should be in that would help for the bar check. |
danmoseley
approved these changes
Jul 22, 2024
joperezr
approved these changes
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #4530
Microsoft Reviewers: Open in CodeFlow