Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4990

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Update dependencies #4990

merged 2 commits into from
Jul 20, 2024

Conversation

joperezr
Copy link
Member

@joperezr joperezr commented Jul 19, 2024

Update Package dependencies.

Depending on timing, we may want to backport this to release/8.1

Microsoft Reviewers: Open in CodeFlow

@joperezr joperezr requested review from danmoseley and eerhardt July 19, 2024 23:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jul 19, 2024
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would vote that we bring these dependency updates into 8.1 as well. They all should be good to update.

I assume you are going to add the new versions to the nuget mirror to get CI green.

@danmoseley
Copy link
Member

@danmoseley danmoseley closed this Jul 20, 2024
@danmoseley danmoseley reopened this Jul 20, 2024
@danmoseley danmoseley enabled auto-merge (squash) July 20, 2024 14:39
@joperezr
Copy link
Member Author

/backport to release/8.1

Copy link
Contributor

Started backporting to release/8.1: https://github.com/dotnet/aspire/actions/runs/10021211412

@joperezr
Copy link
Member Author

/azp run dotnet.aspire

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joperezr
Copy link
Member Author

@eerhardt @sebastienros looks like not all of the images we use are in our container registry yet as my linux build is failing due to dockerhub throttling on elasticsearch one. Found the line to update to fix it, but I need to push the image first. Did we push any instructions anywhere on how to do that?

@joperezr
Copy link
Member Author

nvm, figured it out, also looks like elasticsearch was already pushed.

@danmoseley danmoseley merged commit 2f983d6 into dotnet:main Jul 20, 2024
9 checks passed
@eerhardt
Copy link
Member

Did we push any instructions anywhere on how to do that?

https://github.com/dotnet/aspire/blob/main/docs/updating-container-registry.md

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants