[release/8.0] YARP: add special-case for localhost when setting Host value #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
Servicing-consider
ReubenBond
approved these changes
May 3, 2024
danmoseley
added
Servicing-approved
danmoseley
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4069 to release/8.0
/cc @ReubenBond
Customer Impact
This fix is localized to the YARP Service Discovery integration. It fixes the localhost+HTTPS scenario from the linked bug: #3991. Previously, that would fail due to mismatch between the dev cert and the Host header.
Testing
Tests added, customer validated private build.
Risk
Very low. This behavior is localized to YARP+SD and only takes effect when a URI resolves to localhost and no Host value was explicitly set in YARP configuration.
Regression?
No
Microsoft Reviewers: Open in CodeFlow