[release/8.0] Improve test coverage for YARP Service Discovery and fix issues found #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
the
Servicing-consider
ReubenBond
approved these changes
May 1, 2024
davidfowl
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4036 to release/8.0
/cc @ReubenBond
Customer Impact
This fixes issues when using YARP with the DNS provider - other providers include ports, so they do not hit the issue uncovered by this.
Testing
The PR includes automated tests for YARP with all of the in-built providers.
Risk
Low - this includes tests, and the higher-impact part of the change is localized to YARP integration. The other change (added clause in
ServiceEndPointImpl.ToString()) is to format IPv6IPEndPointinstances with no port (port == 0) in a manner acceptable for inclusion in a URI, which only affects DNS, since only DNS does not provide a port.Regression?
No
Microsoft Reviewers: Open in CodeFlow