Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Ensure xUnit project is in .sln file & fix hyphen in name #4023

Merged
merged 3 commits into from
Apr 30, 2024
Merged

[release/8.0] Ensure xUnit project is in .sln file & fix hyphen in name #4023

merged 3 commits into from
Apr 30, 2024

Conversation

DamianEdwards
Copy link
Member

@DamianEdwards DamianEdwards commented Apr 29, 2024 •
edited
Loading

This is a manual backport of #3959 for GA that only includes the changes for the xUnit scenarios that was already approved in shiproom.

Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 29, 2024
@dotnet-policy-service dotnet-policy-service bot added needs-author-action An issue or pull request that requires more info or actions from the author. and removed needs-author-action An issue or pull request that requires more info or actions from the author. labels Apr 29, 2024
@DamianEdwards DamianEdwards requested a review from timheuer April 29, 2024 21:52
@DamianEdwards
Copy link
Member Author

@timheuer this is ready for you too look at again

timheuer
timheuer approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@timheuer timheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2024
danmoseley
danmoseley approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@danmoseley danmoseley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this part, because it's already fine for our xunit template?

<< #if (CreateTestsProject)
`>> #if (TestFramework != 'None')

@DamianEdwards
Copy link
Member Author

@danmoseley the change to use the TestFramework symbol is only in main, not in release/8.0, as it was introduced to support the MSTest and NUnit variants.

@DamianEdwards DamianEdwards merged commit 03bf47b into release/8.0 Apr 30, 2024
8 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/test-template-fix branch April 30, 2024 00:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timheuer timheuer timheuer approved these changes

@danmoseley danmoseley danmoseley approved these changes

@joperezr joperezr joperezr approved these changes

@phenning phenning Awaiting requested review from phenning

Assignees
No one assigned
Labels
area-templates Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DamianEdwards @timheuer @danmoseley @joperezr