Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Add multiple keyed services tests #3919

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2024

Backport of #3896 to release/8.0

/cc @danmoseley @eerhardt

Customer Impact

Testing

Risk

Regression?

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 24, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 24, 2024
@danmoseley danmoseley requested a review from eerhardt April 24, 2024 15:32
@danmoseley
Copy link
Member

approved - tests only.

@danmoseley
Copy link
Member

@eerhardt looks like this depends on #3293
Abandon? Or port more bits?

@eerhardt
Copy link
Member

@eerhardt looks like this depends on #3293 Abandon? Or port more bits?

I opened #3921 to port that change to release/8.0. I think it would be valuable to get good feedback on the EventHubs component.

@danmoseley danmoseley closed this Apr 27, 2024
@danmoseley danmoseley reopened this Apr 27, 2024
@danmoseley danmoseley enabled auto-merge (squash) April 27, 2024 12:15
@danmoseley
Copy link
Member


D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(86,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddAzureCosmosDBClient' and no accessible extension method 'AddAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]
2024-04-27T12:26:17.5889538Z D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(87,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddKeyedAzureCosmosDBClient' and no accessible extension method 'AddKeyedAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]
2024-04-27T12:26:17.5913929Z D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(88,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddKeyedAzureCosmosDBClient' and no accessible extension method 'AddKeyedAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]

@eerhardt
Or maybe I can look this evening.

eerhardt and others added 3 commits April 27, 2024 12:05
Follow up from #3873

Adding these tests found #3890 which isn't being fixed in this change.
@eerhardt eerhardt force-pushed the backport/pr-3896-to-release/8.0 branch from 837cf45 to 06d925d Compare April 27, 2024 17:08
@eerhardt
Copy link
Member


D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(86,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddAzureCosmosDBClient' and no accessible extension method 'AddAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]
2024-04-27T12:26:17.5889538Z D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(87,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddKeyedAzureCosmosDBClient' and no accessible extension method 'AddKeyedAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]
2024-04-27T12:26:17.5913929Z D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\ConformanceTests.cs(88,17): error CS1061: 'HostApplicationBuilder' does not contain a definition for 'AddKeyedAzureCosmosDBClient' and no accessible extension method 'AddKeyedAzureCosmosDBClient' accepting a first argument of type 'HostApplicationBuilder' could be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\tests\Aspire.Microsoft.Azure.Cosmos.Tests\Aspire.Microsoft.Azure.Cosmos.Tests.csproj]

@eerhardt Or maybe I can look this evening.

Should be fixed now.

@danmoseley danmoseley merged commit a67e742 into release/8.0 Apr 27, 2024
8 checks passed
@danmoseley danmoseley deleted the backport/pr-3896-to-release/8.0 branch April 27, 2024 22:55
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants