Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] AddProject XML doc improvements. #3895

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

mitchdenny
Copy link
Member

@mitchdenny mitchdenny commented Apr 23, 2024

Backport of #3863 to release/8.0
/cc @joperezr

Customer Impact

This is mostly just XML docs for AddProject extension methods. There is one breaking API change. We removed the executable version of WithReplicas as it doesn't work anyway (and it was in the wrong place).

Testing

Its just doc changes, but unit tests run (we weren't testing WithReplicas for executables anyway).

Risk

Low.

Regression?

No.

Microsoft Reviewers: Open in CodeFlow

@mitchdenny mitchdenny changed the base branch from main to release/8.0 April 23, 2024 23:00
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 23, 2024
@mitchdenny mitchdenny self-assigned this Apr 23, 2024
@mitchdenny mitchdenny added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-integrations Issues pertaining to Aspire Integrations packages labels Apr 23, 2024
@mitchdenny mitchdenny added this to the GA milestone Apr 23, 2024
@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 23, 2024
@danmoseley danmoseley enabled auto-merge (squash) April 24, 2024 00:08
@danmoseley danmoseley merged commit 9f7cbbf into release/8.0 Apr 24, 2024
7 checks passed
@danmoseley danmoseley deleted the backport-3863 branch April 24, 2024 00:09
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants