Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] DistributedApplication XML docs #3827

Merged
merged 18 commits into from
Apr 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 19, 2024

Backport of #3745 to release/8.0

/cc @mitchdenny

Customer Impact

First pass at improving XML doc comments with more remarks and some limited example code embedded.

Testing

No impact to executable code.

Risk

Low.

Regression?

Microsoft Reviewers: Open in CodeFlow

mitchdenny and others added 18 commits April 19, 2024 06:37
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the Servicing-consider Issue for next servicing release review label Apr 19, 2024
@mitchdenny mitchdenny added this to the GA milestone Apr 19, 2024
Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving docs

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 20, 2024
@RussKie RussKie merged commit 76b788b into release/8.0 Apr 21, 2024
7 checks passed
@RussKie RussKie deleted the backport/pr-3745-to-release/8.0 branch April 21, 2024 23:34
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants