-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken find token image in HTTP #3635
Conversation
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8656686212 |
Given that we don't have any external images, would just doing |
'self' would have been simpler. IMO the PR as it is works and could allow external images if needed by a feature at some point. I think we go with this for now. Change more if needed. |
Approved and thanks for the tests. Just wondering if any XSS concerns with any external site when we specify https |
We missed the snap anyway, if @tlmii you believe you need to modify this there is time. |
No. An image can't be used to run scripts. |
Fixes #3603
If the website is http then allow http or https images.
If the website is https then only allow https images.
Working:
Microsoft Reviewers: Open in CodeFlow