Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesService: check if configuration file exists before attempting to construct client #3498

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Apr 8, 2024

This reduces log noise and first-chance exception noise and might improve startup reliability marginally.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 8, 2024
@ReubenBond ReubenBond added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 8, 2024
@ReubenBond ReubenBond merged commit a5b5b42 into main Apr 9, 2024
8 checks passed
@ReubenBond ReubenBond deleted the rebond/KubernetesService-check-file-exists-first branch April 9, 2024 02:04
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants