Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SqlClient component activity name #3118

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix SqlClient component activity name #3118

merged 2 commits into from
Mar 25, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Mar 23, 2024

The conformance tests should have failed but they did not. And did not for other components with the same problem (Redis). We need to investigate.

Note that traces work fine without this change because we are calling AddSqlClientInstrumentation() which uses the same wrong activity name. But this could be an issue if other libraries are using the name coming from the nuget package.

/cc @rajkumar-rangaraj @reyang since the azure sdk has the same problem.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 23, 2024
@rajkumar-rangaraj
Copy link

Good catch, we will fix this in Azure SDK.
This issue may not impact the Azure SDK as we back off from internal SQL instrumentation if the customer brings a reference to OpenTelemetry.Instrumentation.SqlClient package.

@eerhardt
Copy link
Member

The conformance tests should have failed but they did not.

We don't have real SQL tests running in CI yet. They will be with #3034. You can see that they failed because @radical is trying to adjust the tests' ActivitySourceName.

@eerhardt eerhardt merged commit 544f8e4 into main Mar 25, 2024
8 checks passed
@eerhardt eerhardt deleted the sebros/activity branch March 25, 2024 15:57
radical pushed a commit to radical/aspire that referenced this pull request Mar 25, 2024
* Fix SqlClient component activity name

* Update instructions
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants