Retry on watch longpoll disconnect. #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
mitchdenny
commented
Mar 20, 2024
mitchdenny
commented
Mar 20, 2024
davidfowl
reviewed
Mar 20, 2024
davidfowl
approved these changes
Mar 20, 2024
davidfowl
reviewed
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2422
This PR introduces a Polly resilience pipeline to retry the watch resource long poll operation when it disconnects. We detect the disconnect by overving that the exception that is thrown has an inner exception of type
EndOfStreamException. If we see this then we'll log a debug message for future supportability purposes, but otherwise exit.We swallow
OperationCancelledExceptionsand exit cleanly. All other exceptions are logged.Microsoft Reviewers: Open in CodeFlow