Rename FluentAppBar/FluentAppBarItem to AspireAppBar/AspireAppBarItem #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
drewnoakes,
vnbaaij,
adamint and
kvenkatrajan
dotnet-issue-labeler
bot
added
the
area-integrations
vnbaaij
approved these changes
Mar 6, 2024
|
Couple of other changes needed when going to the Fluent version of these components:
But once you have done that, you'll get this: |
JamesNK
approved these changes
Mar 6, 2024
|
@vnbaaij nice |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The official FluentAppBar component is coming in a future version of FluentUI Blazor library. It is already showing up in preview builds on nuget.org.
We will eventually move to using the official component once it is released. But in the interim we don't want there to be conflicts when it is released. As it stands right now, updating our references to a package version that includes the official component causes errors in the Aspire dashboard because of naming conflicts (both our component and the official one are FluentAppBar/FluentAppBarItem).
To ease that a little bit, we'll go ahead and rename our component to AspireAppBar/AspireAppBarItem. Then we can update to the latest versions of the component library for other purposes (e.g. #2568) without needing to make further, unrelated changes.
Note that there's no functional changes in this PR. Its just a rename of the component.
Microsoft Reviewers: Open in CodeFlow