Limit opacity override to resource select controls #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
drewnoakes,
leslierichardson95,
adamint and
kvenkatrajan
|
I knew it would come back: #2123 (comment) 😄 |
JamesNK
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2123 added an override to the
--disabled-opacitycss variable because of how the disabled replica set entries looked in the resource selects. Unfortunately it applied globally and caused things that should look disabled to not look disabled enough (see comment #2572 (review)).This change adds a
resource-listclass to denote that a particular fluent-select is being used for the above purpose and modifiesapp.cssto only change the--disabled-opacityvariable for those particular elements (and their descendants).There's no change to the appearance of those elements:
But now the difference between enabled/disabled menu button is more obvious (compare with screenshot in the PR comment above):
It's possible that its still too subtle, or we want to do something else to set it off when its disabled, but I think this change is appropriate regardless to limit the global impact of the
--disabled-opacityvariable.Microsoft Reviewers: Open in CodeFlow