Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a bunch of dependencies to latest #2663

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Mar 6, 2024

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 6, 2024
@radical
Copy link
Member

radical commented Mar 6, 2024

dependabot is failing - https://github.com/dotnet/aspire/network/updates/796259011
Screenshot 2024-03-05 at 20 13 01

IIUC, it should have been able to run for the sdk-style project but it failed with Property 'NetCurrent' was not found.. This property is set by arcade. I hope it does a restore before trying to read the project file, though https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#nuget-cli suggests otherwise. (and updater code).

If that is correct then we would need to provide a default value for this property, matching the current value in Arcade. Restricting that value to be set only for dependabot run would be good.

cc @danmoseley - does that sound correct?

@eerhardt
Copy link
Member Author

eerhardt commented Mar 6, 2024

@radical - see dependabot/dependabot-core#8490 (comment)

@eerhardt
Copy link
Member Author

eerhardt commented Mar 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@eerhardt eerhardt enabled auto-merge (squash) March 6, 2024 15:15
@eerhardt eerhardt merged commit bcdf1de into dotnet:main Mar 6, 2024
8 checks passed
@eerhardt eerhardt deleted the UpdateDependencies branch March 6, 2024 18:51
@danmoseley
Copy link
Member

Maybe I should make a branch, with this directory.Packages.props, that is hacked enough that dependabot works in it, and we can periodically merge its changes back to main..

@radical
Copy link
Member

radical commented Mar 6, 2024

You could try <NetCurrent Condition="'$(ArcadeSdkVersion)' == ''">net8.0</NetCurrent> which should be triggered when arcade is not restored, as that property is being set in arcade targets.
Or maybe even $(ArcadeSdkBuildTasksAssembly) != ''.

And we can add and '$(ContiunuousIntegrationBuild)' != 'true', so it does not trigger on our CI.

If it works then it might be good enough for main.. maybe?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants