Update IDE execution spec for Aspire v1 release #2631
Conversation
1. Add support for varied/multiple launch configurations 2. Specify how IDE should report errors 3. Specify how requests will be versioned
dotnet-issue-labeler
bot
added
the
area-engineering-systems
|
@rafaelldi please review/comment, any feedback would be very appreciated |
karolz-ms
added
area-tooling
area-orchestrator
and removed
area-engineering-systems
|
@vijayrkn FYI |
|
Thanks for mentioning me! |
| @@ -71,13 +78,7 @@ The payload is best explained using an example: | |||
| "args": [ | |||
There was a problem hiding this comment.
Should these args now apply to all projects from the launch_configurations list (same with the env property)?
There was a problem hiding this comment.
In Aspire version 1 release only a single launch configuration instance, of type
project, can be used as part of a run session request
Oh, I see that there will be only one project per request in this list.
There was a problem hiding this comment.
Yes, the idea is that env and args apply to all configurations that are part of the request and form a "baseline" of sorts. If that is not desired for certain configuration(s), these properties could be overridden on the individual configuration level. We do not have this scenario today, but I could imagine a need like that emerging in future.
| | `type` | Launch configuration type indicator; must be `project`. | Required | | ||
| | `project_path` | Path to the project file for the program that is being launched. | Required | | ||
| | `mode` | Specifies the launch mode. Currently supported modes are `Debug` (run the project under the debugger) and `NoDebug` (run the project without debugging). | Optional, defaults to `Debug`. | | ||
| | `launch_profile` | Invocation arguments for the program (modeled as array of strings). | Optional | |
There was a problem hiding this comment.
As far as I understand, this property is now unused (as well as disable_launch_profile). For example, if you start an Aspire host project with dotnet run, it will run every project with the --no-launch-profile option. This is because if you run the project with launch_profile received, you will have conflicting ports because Aspire uses the port from the profile in the proxy. So, how to work with these properties correctly?
There was a problem hiding this comment.
The invocation via dotnet run does not really use this protocol today, so it is not applicable.
For Visual Studio, dotnet watch (work pending), and presumably Rider, the property reflects the launch profile the user requested in the app model. It is the launch profile for the service program, which is distinct from the launch profile for the application host program. It is up to the IDE/CLI to apply the requested launch profile to the service program, and it is up to the developer to ensure that application host launch profile and the service(s) launch profile(s) do not conflict.
Not sure if I fully understand the question; hope this helps anyway.
|
Thanks @rafaelldi and @BillHiebert ! |
Main changes include:
Microsoft Reviewers: Open in CodeFlow