Adds phpMyAdmin to MySql component #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the phpMyAdmin container image when `WithPhpMyAdmin` is used on a MySql container.
dotnet-issue-labeler
bot
added
the
area-codeflow
|
This is looking pretty good. One of the things that I wanted to do for Postgres but didn't get to in P3 was make it so that if you do WithPgAdmin(...) on one resource, but not the other, you don't get the server registered in the PG admin container. This code has the same issue but I wouldn't block it for that. |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
* Adds phpMyAdmin to MySql component This adds the phpMyAdmin container image when `WithPhpMyAdmin` is used on a MySql container. * Added tests * Added mysql playground
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the phpMyAdmin container image when
WithPhpMyAdminis used on a MySql container.Fixes #1936
Why not adminer?
Adminer doesn't support very well multiple host configurations nor the docker internal host names very well in my testing.
Single MySqlInstance (automatic login):
Multiple instances (would show a drop-down in phpMyAdmin and then would have to login)
Microsoft Reviewers: Open in CodeFlow