Publishing dashboard assets to blob storage in preparation of docker image generation #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
joperezr
added
area-engineering-systems
radical
reviewed
Jan 25, 2024
eng/Publishing.props
Outdated
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <_InstallersToPublish Include="$(ArtifactsDir)**\*.wixpack.zip" Condition="'$(PostBuildSign)' == 'true'" /> | ||
| <_InstallerManifestFilesToPublish Include="$(ArtifactsDir)VSSetup\$(Configuration)\Insertion\**\*.zip" /> | ||
| <_DashboardFilesToPublish Include="$(DashboardPublishedArtifactsOutputPath)\**\*.zip" /> |
There was a problem hiding this comment.
nit: this can be moved into the new target, and we can check that it is not empty.
There was a problem hiding this comment.
Actually I had to remove this due to the fact that we currently (incorrectly) call publish more than once, and the first time we do so we haven't yet created the publish assets, so this is failing. I'll log an issue to track the work of simplifying our build (today it requires one call to build.cmd and one manual build of the workloads.proj, but ideally we would only need to call build.cmd). Once we move to that model, then we can add the check back.
radical
approved these changes
Feb 1, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
…image generation (dotnet#1860) * Publishing dashboard assets to blob storage in preparation of docker image generation * Add definition of dashboard published directory to Publishing.props * Address PR Feedback * Remove error when empty dashboard publish assets
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
…image generation (dotnet#1860) * Publishing dashboard assets to blob storage in preparation of docker image generation * Add definition of dashboard published directory to Publishing.props * Address PR Feedback * Remove error when empty dashboard publish assets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1621
After chatting with @MichaelSimons, we agreed that in order for dotnet-docker repo to consume our build output, they require us to push our dashboard assets into blob storage. This PR is first ensuring that we create zips for each of the published platforms of the dashboard app, and then it adds them into the items to push to blob feed so that arcade can ensure that they get pushed.
FYI @lbussell
Microsoft Reviewers: Open in CodeFlow