Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better layout for the LogDetailsDialog #154

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

vnbaaij
Copy link
Contributor

@vnbaaij vnbaaij commented Oct 9, 2023

Made some adjustments to the LogDetailsDialog layout. LMK what you think.

@vnbaaij vnbaaij requested a review from JamesNK October 9, 2023 19:48
@JamesNK
Copy link
Member

JamesNK commented Oct 10, 2023

Before/after screenshots?

All the dialogs are a mess at the moment. Duplication, problems with long content, etc.

@vnbaaij
Copy link
Contributor Author

vnbaaij commented Oct 10, 2023

Before: Fluent and system tooltip on copy button, overflow in long cells not visible and not tooltips:

LogDetails-before

After: Only Fluent tooltip on copy button. Ellipses on overflow on cells and a tool tip showing the complete cell text
LogDetails-after

@JamesNK JamesNK merged commit 65b6fc9 into main Oct 10, 2023
@JamesNK JamesNK deleted the vibaaij/log-details-layout branch October 10, 2023 08:53
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants