Include Executable WithArgs in manifest #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
Kahbazi
commented
Dec 12, 2023
| } | ||
| } | ||
|
|
||
| if (args.Count > 0) |
There was a problem hiding this comment.
Previously if ExecutableResource.Args was empty the "args" would be in the manifest with an empty array. I changed this to not include the args to be consistence with Container manifest.
There was a problem hiding this comment.
Add a test to verify this?
Kahbazi
commented
Dec 12, 2023
| /// <param name="builder">The resource builder.</param> | ||
| /// <param name="args">The arguments to be passed to the executable when it is started.</param> | ||
| /// <returns>The <see cref="IResourceBuilder{T}"/>.</returns> | ||
| public static IResourceBuilder<T> WithArgs<T>(this IResourceBuilder<T> builder, params string[] args) where T : ExecutableResource |
There was a problem hiding this comment.
I copied this from #1363 to be able to produce the bug and write test for it.
| { | ||
| context.Writer.WriteStartArray("args"); | ||
|
|
||
| foreach (var arg in args ?? []) |
There was a problem hiding this comment.
args will never be null here now right, so you can avoid the ??
| @@ -103,6 +103,32 @@ public void EnsureContainerWithArgsEmitsContainerArgs() | |||
| arg => Assert.Equal("more", arg.GetString())); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void EnsureExecutableWithArgsEmitsExecutableArgs() | |||
There was a problem hiding this comment.
Perhaps add a variant that ensures args are added via the extension method even if the resource itself had no args when defined.
|
Thanks for the contribution @Kahbazi! |
Kahbazi
pushed a commit
to Kahbazi/aspire
that referenced
this pull request
Dec 13, 2023
This reverts commit 0c3d014.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1362
Microsoft Reviewers: Open in CodeFlow