Allow reading connection strings from config #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This allows the existing components (postgres, sql, redis) to read from config as a fallback after getting their own connection string. #120
davidfowl
commented
Oct 9, 2023
| @@ -44,6 +44,6 @@ private static void WriteRedisComponentToManifest(Utf8JsonWriter jsonWriter, str | |||
| public static IDistributedApplicationComponentBuilder<T> WithRedis<T>(this IDistributedApplicationComponentBuilder<T> builder, IDistributedApplicationComponentBuilder<IRedisComponent> redisBuilder, string? connectionName = null) | |||
| where T : IDistributedApplicationComponentWithEnvironment | |||
| { | |||
| return builder.WithReference(redisBuilder); | |||
| return builder.WithReference(redisBuilder, connectionName); | |||
There was a problem hiding this comment.
This was a bug I introduced.
mitchdenny
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #120
PS: Once we do #132, this logic will only exist in a single place.