Simplify search handling #1324
Merged
Simplify search handling #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these cases, callback methods are not needed and binding directly to the field is sufficient.
|
It looks like some of the intent in that HandleClear method got lost along the way. I think it was intended to make sure the _filter didn't get set to null (because value on FluentSearch is |
|
@tlmii is there something you'd like to see changed here? |
tlmii
approved these changes
Dec 18, 2023
vnbaaij
approved these changes
Dec 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these cases, callback methods are not needed and binding directly to the field is sufficient.
Microsoft Reviewers: Open in CodeFlow