Add Menu Grouping for Logs #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
requested review from
JamesNK,
smitpatel,
dbreshears and
leslierichardson95
|
Screenshot: |
smitpatel
approved these changes
Oct 6, 2023
dbreshears
approved these changes
Oct 6, 2023
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/dotnet/aspire-private-planning/issues/543
Adds a "Logs" menu group and groups the existing log types underneath it. That issue also asked for "Semantic Logs" to be renamed "Structured". I did this on the menu and the title of the page, but didn't change the page name/route and all links to it yet to make sure the name sticks.
There's a bug in the current nav menu where when you click on a menu grouping that doesn't have an href, you get into the flashing menu scenario that we've seen in other cases. I put in a workaround for it that we can remove when we update to the new nav menu coming soon.