Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scriptPath argument to AddNodeApp #1095

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Add scriptPath argument to AddNodeApp #1095

merged 7 commits into from
Nov 29, 2023

Conversation

mitchdenny
Copy link
Member

Fixes #1094

Adds scriptPath argument and makes workingDirectory optional. The extension method derives this value from the script path.

@mitchdenny mitchdenny requested a review from davidfowl November 29, 2023 04:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 29, 2023
@mitchdenny mitchdenny merged commit 750f8fc into main Nov 29, 2023
@mitchdenny mitchdenny deleted the addnodeapp-tweaks branch November 29, 2023 05:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change signature for AddNodeApp(...)
2 participants
@mitchdenny @davidfowl