Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VSTest on Windows without globally installed SDK #6182

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Sep 15, 2020

Workaround until tracking issue dotnet/sdk#13611 is fixed. Unblocks dotnet/linker#1471. Not adding support for x86 intentionally as this is just a workaround.

cc @alexperovich @nohwnd

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good (not much experience in this area though)

@ViktorHofer ViktorHofer merged commit 947ad5a into master Sep 16, 2020
@am11 am11 mentioned this pull request Oct 9, 2020
@ViktorHofer ViktorHofer deleted the ViktorHofer-dotnetroot-vstest branch October 9, 2020 13:51
ViktorHofer added a commit that referenced this pull request Oct 9, 2020
ViktorHofer added a commit that referenced this pull request Oct 9, 2020
* Update the SDK to 5.0 RC2

We want to update the SDK from 5.0 RC1 to RC2.

* Add the 5.0 branch to the pipeline yml

* Revert "Fix VSTest invocation (#6189)"

This reverts commit 93efe55.

* Revert "Fix VSTest on Windows without globally installed SDK (#6182)"

This reverts commit 947ad5a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants