Version light command packages #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmat
reviewed
May 14, 2020
tmat
reviewed
May 14, 2020
| @@ -62,6 +62,7 @@ | |||
| <VisualStudioSetupInsertionPath>$([MSBuild]::NormalizeDirectory('$(VisualStudioSetupOutputPath)', 'Insertion'))</VisualStudioSetupInsertionPath> | |||
| <VisualStudioSetupIntermediateOutputPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'VSSetup.obj', '$(Configuration)'))</VisualStudioSetupIntermediateOutputPath> | |||
| <VisualStudioBuildPackagesDir>$([MSBuild]::NormalizeDirectory('$(VisualStudioSetupOutputPath)', 'DevDivPackages'))</VisualStudioBuildPackagesDir> | |||
| <LightCommandPackagesDir>$(ArtifactsDir)LightCommandPackages/</LightCommandPackagesDir> | |||
| <LightCommandObjDir>$(ArtifactsObjDir)/LightCommandPackages</LightCommandObjDir> | |||
There was a problem hiding this comment.
Is this the right place for this definition? Seems very specific to Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk, so I'd think the Sdk.props file of that package would be a better home for definitions of these properties.
There was a problem hiding this comment.
Is there a doc on what "light command packages" are? I'm also wondering why they need a specialized directory vs. just using the intermediate output directory of whatever project that uses the SDK.
mmitche
approved these changes
May 15, 2020
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/core-eng/issues/9825
Creates packages named via Arcade versioning semantics like
LightCommandPackages-5.0.0-ci.zip- local dev buildor
LightCommandPackages-5.0.0-ci-win-x64.zip- local dev build in a repo which defines an optional suffix viaeng/AfterSolutionBuild.propsFYI @NikolaMilosavljevic