Workaround to allow rc1 uptake #15076
Conversation
This works around dotnet/sdk#43339 for Arcade projects, unblocking updating to .NET SDK 9.0.100-rc.1, even when official or PR builds use Visual Studio 17.11.
| @@ -184,4 +184,29 @@ | |||
| </ItemGroup> | |||
| </Target> | |||
|
|
|||
| <!-- BEGIN workaround for https://github.com/dotnet/sdk/issues/43339; remove after updated to VS 17.12 or a future 17.11 patch --> | |||
| <Target Name="WorkaroundDotnetSdk43339" BeforeTargets="ResolvePackageAssets" Condition=" '$(MSBuildRuntimeType)' == 'Full' and $([MSBuild]::VersionLessThan($(MSBuildVersion), 17.12.0))"> | |||
There was a problem hiding this comment.
Any other targets that might load NuGet and hit this?
There was a problem hiding this comment.
Probably but I don't know of any today. I guess it'd be maximally conservative to do this as an InitialTargets or something, but that feels pretty bad . . .
There was a problem hiding this comment.
since arcade flows directly into the repos any cases should be visible in the flow pr and easy fix without making anything worse
There was a problem hiding this comment.
I guess another repo could always add a new target like this:
<Target Name="MyRepoWorkaroundDotnetSdk43339" DependsOnTargets="WorkaroundDotnetSdk43339" BeforeTargets="MyBrokenTarget" />
There was a problem hiding this comment.
Yeah, the reason to push this in Arcade is to avoid having to work around everywhere but it's possible to do so.
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/arcade/actions/runs/10817834607 |
This works around dotnet/sdk#43339 for Arcade projects, unblocking
updating to .NET SDK 9.0.100-rc.1, even when official or PR builds use
Visual Studio 17.11.
Vetted in dotnet/msbuild#10643.