[release/8.0] Prepend wix tooling to the path. #14772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some newer images, WiX tooling is on the path, so we should prepend rather than append to use the desired version. Note that we put the tools on the path because the "wix tool" we run may actually be a script that invokes tools.
mmitche
changed the title
joeloff
approved these changes
May 16, 2024
Cosifne
added a commit
to Cosifne/roslyn
that referenced
this pull request
Jul 10, 2024
…se branch As offline discussed, the goal is to flow dotnet#73507 which carries dotnet/arcade#14772 into servicing branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some newer images, WiX tooling is on the path, so we should prepend rather than append to use the desired version. Note that we put the tools on the path because the "wix tool" we run may actually be a script that invokes tools.
To double check: