Skip to content

Commit

Permalink
Workaround NuGet breaking change (#2165)
Browse files Browse the repository at this point in the history
NuGet removed Manifest.Save(Stream, bool) in the latest version.
Since NuGet is part of MSBuild our task is forcibly upgraded to the
latest version when running in the latest SDK.  This results in a
missing method exception.

Workaround it by calling an API that NuGet didn't remove.  This can
potentially cause failures in GenerateNuSpec because it will now run
Validation, however anyone using the Pack task in our package should
already be passing validation since NuGet runs the same validation
when reading the Manifest.
  • Loading branch information
ericstj authored Mar 5, 2019
1 parent 1bcf7d7 commit 72de932
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ private void WriteNuSpecFile()

using (var file = File.Create(OutputFileName))
{
manifest.Save(file, false);
manifest.Save(file);
}
}

Expand Down

0 comments on commit 72de932

Please sign in to comment.